refactor: replace manual position calculation with getPosition method…

… in hit functions
LittleTheFu · Jan 10, 2025 · 0d8da57 · 0d8da57
1 parent 2f52a50
commit 0d8da57
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/geometry/ball.cpp b/geometry/ball.cpp
@@ -115,7 +115,7 @@ bool Ball::hit(const Ray &ray, HitRecord &record) const
 
     record.transform = m_transform;
 
-    const Vector3 localPoint = newRay.origin + record.t * newRay.dir;
+    const Vector3 localPoint = newRay.getPosition(record.t);
     record.point = m_transform.transformPoint(localPoint);
     record.localPoint = localPoint;
 

diff --git a/geometry/plane.cpp b/geometry/plane.cpp
@@ -27,7 +27,7 @@ bool Plane::hit(const Ray &ray, HitRecord &record) const
         return false;
 
     //refactor later...
-    Vector3 localPoint = newRay.origin + record.t * newRay.dir;
+    Vector3 localPoint = newRay.getPosition(record.t);
     Vector3 localNormal = Common::LOCAL_NORMAL;
 
     //refactor later...

diff --git a/geometry/tri.cpp b/geometry/tri.cpp
@@ -67,7 +67,7 @@ bool Tri::hit(const Ray &ray, HitRecord &record) const
         return false;
 
     //reduntant code,refactor later...
-    Vector3 localPoint = localRay.origin + record.t * localRay.dir;
+    Vector3 localPoint = localRay.getPosition(record.t);
     Vector3 _objPoint = frame.pointToWorld(localPoint);
 
     Vector3 pixelNormal = getWeightedNormal(_objPoint);