Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make artifact interval a 2d array #691

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Make artifact interval a 2d array #691

merged 1 commit into from
Nov 21, 2023

Conversation

samuelbray32
Copy link
Collaborator

Description

In artifact detection, intervals with artifacts were being saved as a list of tuples rather than a 2D array, which is inconsistent with the valid_times in the IntervalList table. This PR changes to make consistent.

Checklist:

  • This PR should be accompanied by a release: No
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from CBroz1 November 21, 2023 19:46
@edeno edeno changed the title Make aritifact interval a 2d array Make artifact interval a 2d array Nov 21, 2023
@edeno edeno self-requested a review November 21, 2023 20:44
@edeno edeno merged commit 9d9b96b into master Nov 21, 2023
9 checks passed
@edeno edeno deleted the artifact_interval_fix branch November 21, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants