Add detail to sharing notebook #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
edeno
reviewed
Dec 22, 2023
edeno
requested changes
Dec 22, 2023
There was a problem hiding this comment.
Some spelling, grammar, and clarification requests. Can you also document Loren's request as well: #561 (comment)
Also if possible (and if it hasn't already happened), please format the notebook with black. (Should be able to do this in VScode by right-click -> format notebook)
Running |
CBroz1
reviewed
Dec 22, 2023
edeno
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #561
share_data_to_kachery, Helper function for adding data to kachery #729Checklist:
CITATION.cffCHANGELOG.md