Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-actions docs fixes #828

Merged
merged 3 commits into from
Feb 13, 2024
Merged

gh-actions docs fixes #828

merged 3 commits into from
Feb 13, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Feb 12, 2024

Description

  • Addresses previous docs publish fail.
    • mike dependency saw latest as already existing. Added -u flag to update latest
    • hatch dependency not reporting updated version, switched to setting version in environment during action
  • Collapse linting and codespell workflows under lint banner.
  • Exclude test_branch from other workflows to isolate docs issues
  • Add metadata to notebook raising warnings in docs build
  • Rename variables causing docstring API warnings in utils/

Checklist:

  • This PR should be accompanied by a release: No
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md: Don't think necessary
  • I have added/edited docs/notebooks to reflect the changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1 CBroz1 requested a review from edeno February 12, 2024 20:12
@CBroz1 CBroz1 marked this pull request as ready for review February 12, 2024 20:13
docs/mkdocs.yml Outdated Show resolved Hide resolved
@CBroz1 CBroz1 requested a review from edeno February 13, 2024 15:50
Copy link
Collaborator

@edeno edeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only downside to combining the workflows is that it is slightly more work to tell what failed.

@edeno edeno merged commit 2532419 into LorenFrankLab:master Feb 13, 2024
7 checks passed
edeno added a commit that referenced this pull request Feb 20, 2024
* Fault-permit insert and remove mutual exclusivity protections on Merge (#824)

* #719, #804, #212

* #768

* Add merge delete and populate

* Changes following PR review @edeno

* Replace delayed import of ImportedSpikeSorting

* Update CITATION.cff (#826)

* Update CITATION.cff

* Update change log

* Update ref

* Add MUA notebook and fix numbering.

* Only apply include labels filter if include_labels not empty (#827)

* dont skip unit if include_labels list is empty

* update check for np array size

* gh-actions docs fixes (#828)

* Update 'latest' in docs deploy

* Docs bugfix. Rename Link action, incorporate cspell.

* MUA as own heading

* Update README.md

* Fix citation

* Fix citation

* include all relevant restrictions on video file

* Proposed structure for user roles. (#832)

* Add roles

* Remove use of unix user group. Add note for retroactive role assign

* Add docs on roles and external tables. Reduce key length

* Fix test for update of position tools (#835)

Related to single LED halving the data bug

* fix build error in mamba and restriction for dlc

* flush stdout before converting mp4

* Fix notebook name (#840)

* remove deprecated yaml.safe_load function

* Fix test

* replace deprecated yaml.safe_load function

* only call no_transaction_make if video key not present

---------

Co-authored-by: Chris Brozdowski <[email protected]>
Co-authored-by: Eric Denovellis <[email protected]>
Co-authored-by: Eric Denovellis <[email protected]>
edeno added a commit that referenced this pull request Feb 21, 2024
* allow for  multicamera epochs

* change VideoFile definition

* update video_file_num iteration

* add update methods

* change VideoFile restriction in get_video_path

* modify formatting in position_dlc_project

* allow selective video selection in pose estimation

* add NotImplementedError to DLCProject insert

* allow for video file addition after proj creation

* fix add_video_files

* fix video_file_num determination in VideoFile

* modify add_video_files method

* change call to add_video_files

* modify interval_list_name call

* Fix linting errors

* Tested DLC multicam pipeline  (#841)

* Fault-permit insert and remove mutual exclusivity protections on Merge (#824)

* #719, #804, #212

* #768

* Add merge delete and populate

* Changes following PR review @edeno

* Replace delayed import of ImportedSpikeSorting

* Update CITATION.cff (#826)

* Update CITATION.cff

* Update change log

* Update ref

* Add MUA notebook and fix numbering.

* Only apply include labels filter if include_labels not empty (#827)

* dont skip unit if include_labels list is empty

* update check for np array size

* gh-actions docs fixes (#828)

* Update 'latest' in docs deploy

* Docs bugfix. Rename Link action, incorporate cspell.

* MUA as own heading

* Update README.md

* Fix citation

* Fix citation

* include all relevant restrictions on video file

* Proposed structure for user roles. (#832)

* Add roles

* Remove use of unix user group. Add note for retroactive role assign

* Add docs on roles and external tables. Reduce key length

* Fix test for update of position tools (#835)

Related to single LED halving the data bug

* fix build error in mamba and restriction for dlc

* flush stdout before converting mp4

* Fix notebook name (#840)

* remove deprecated yaml.safe_load function

* Fix test

* replace deprecated yaml.safe_load function

* only call no_transaction_make if video key not present
---------

Co-authored-by: dpeg22 <[email protected]>
Co-authored-by: CBroz1 <[email protected]>
Co-authored-by: Samuel Bray <[email protected]>
Co-authored-by: Chris Brozdowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants