Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of waveforms_dir consistent #857

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Make use of waveforms_dir consistent #857

merged 3 commits into from
Mar 7, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Mar 1, 2024 •
edited
Loading

Description

Checklist:

  • This PR should be accompanied by a release: no
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from CBroz1 March 1, 2024 18:57
@CBroz1
Copy link
Member

CBroz1 commented Mar 7, 2024

Ready to merge pending conflict resolution

@edeno edeno merged commit 0b944cd into master Mar 7, 2024
5 checks passed
@edeno edeno deleted the waveforms_dir branch March 7, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce waveform config redundancy
3 participants
@samuelbray32 @CBroz1 @edeno