Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-referencing option in lfp artifact detection #863

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix non-referencing option in lfp artifact detection #863

merged 2 commits into from
Mar 7, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Mar 7, 2024 •
edited
Loading

Description

Fixes #862, #850

  • Assume no referencing if no referencing key present in artifact_params
  • Only apply referencing if ref_on is True
  • make referencing a bool in difference_artifact_detector` (no functional change)

Checklist:

  • This PR should be accompanied by a release: no
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from edeno March 7, 2024 23:37
@edeno edeno merged commit d7dcc6b into master Mar 7, 2024
9 checks passed
@edeno edeno deleted the lfp_artifact_referencing branch March 7, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LFP artifact referencing inconcistency
2 participants
@samuelbray32 @edeno