-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix contact size for 128c-4s6mm6cm-15um-26um-sl.yml #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fix in geom looks good (I'm not aware of the contact_size field being used downstream, I think the longer device name, plus the ids and relative x y z coordinates within the file are used directly for spikesorting last i checked)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values end up in Probe.Electrode
as contact_size
. I haven't tested spikesorting, but I would suspect that it pulls the info from the probe device in the nwbfile (came up with Jen's data last summer for the relative positions of electrodes).
Also, should change it here too
Matching with [this PR](LorenFrankLab/trodes_to_nwb#103 (review)) in `trodes_to_nwb`
@samuelbray32 by the way, do you know what's going on with the tests here? |
Oh I hadn't caught that. No that looks like something outside of us has changed in the last 4 months. I'll poke around |
Tests pass locally, let me see if can find the offending package |
Looking at the errors, I suspect the cause is the latest numpy version. |
Yeah, I can create and solve the failed test locally by changing numpy version. Suspect it's in the |
Solved the ones related to the wrong shape in position. Does stem from some change in Still working on the |
Working on updating for numpy on #104 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 25 25
Lines 2433 2433
=======================================
Hits 2198 2198
Misses 235 235 ☔ View full report in Codecov by Sentry. |
Fixes #102