Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non ptp epoch restriction #81

Merged
merged 17 commits into from
Feb 3, 2024
Merged

Non ptp epoch restriction #81

merged 17 commits into from
Feb 3, 2024

Conversation

samuelbray32
Copy link
Collaborator

Resolves #80

  • When matching trodes timestamps from position tracking and rec file, first restrict the rec trodes timestamps to those corresponding to a rec system clock time within the epoch
  • Enables accurate mapping when trodes timestamps are not uniques across epochs, but are unique within the epoch
  • Gives minor speed and efficiency improvements
  • Added documentation for get_position_timestamps()

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8a907f4) 90.70% compared to head (d6ec5be) 90.56%.

❗ Current head d6ec5be differs from pull request most recent head 5cc0485. Consider uploading reports for the commit 5cc0485 to get more accurate results

Files Patch % Lines
src/trodes_to_nwb/spike_gadgets_raw_io.py 62.50% 3 Missing ⚠️
src/trodes_to_nwb/convert_ephys.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   90.70%   90.56%   -0.14%     
==========================================
  Files          25       25              
  Lines        2398     2407       +9     
==========================================
+ Hits         2175     2180       +5     
- Misses        223      227       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelbray32 samuelbray32 marked this pull request as ready for review January 30, 2024 17:34
@samuelbray32 samuelbray32 requested a review from edeno January 30, 2024 17:34
@samuelbray32
Copy link
Collaborator Author

Confirmed that these changes resolve conversion with non-ptp, non-unique trodes timestamps conversions

edeno
edeno previously approved these changes Jan 31, 2024
environment.yml Outdated Show resolved Hide resolved
@edeno edeno self-requested a review February 3, 2024 00:13
edeno
edeno previously approved these changes Feb 3, 2024
pyproject.toml Outdated Show resolved Hide resolved
@edeno edeno self-requested a review February 3, 2024 00:17
edeno
edeno previously approved these changes Feb 3, 2024
@edeno edeno merged commit a52dfa1 into main Feb 3, 2024
7 checks passed
@edeno edeno deleted the non_ptp_epoch_restriction branch February 3, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict lookup of non-ptp position timestampt to specific epoch
2 participants