Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image asset embedded property #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beve
Copy link
Contributor

@beve beve commented Apr 29, 2022

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures

Pull request type

  • Bugfix

What is the current behavior?

Image asset can't be described as embedded, so player try to load them remotely, even if they are embedded as assets.

Issue Number: #21

What is the new behavior?

Player displays correctly the embedded images.

Does this introduce a breaking change?

  • Yes
  • No

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2022

⚠️ No Changeset found

Latest commit: 14f8680

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant