Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/poetry #647

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Feat/poetry #647

wants to merge 5 commits into from

Conversation

jjfantini
Copy link

@jjfantini jjfantini commented Dec 4, 2024

Changing the package requirements to poetry for easier management. Migrated all setup configs. Tests are all passing.

Description by Korbit AI

What change is being made?

Move configuration management to pyproject.toml using Poetry for dependency management, update dependencies, and refine linting and testing configurations.

Why are these changes being made?

Consolidating configurations into pyproject.toml enhances maintainability and adoption of Poetry streamlines dependency management, ensuring compatibility with Python 3.10. This update also organizes linting and testing tools to ensure consistent quality checks and reduces redundancy across the config files by removing setup.cfg and updating the .gitignore.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

using local installation we can use the updated code that includes a
version in the pyproject.toml file. This allows for better version
solving
@jjfantini jjfantini requested a review from grzesir as a code owner December 4, 2024 17:57
Copy link
Contributor

korbit-ai bot commented Dec 4, 2024

Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use /korbit-review.

Copy link
Contributor

@grzesir grzesir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stick to pip please? It is not necessary to switch to poetry, and a switch like this will break a lot of our automations

@jjfantini
Copy link
Author

jjfantini commented Dec 5, 2024

I have updated the workflow to work with poetry. DO you have any other migrations that I should be aware of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants