Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable snq if secret is not set #2621

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Disable snq if secret is not set #2621

merged 2 commits into from
Oct 29, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 28, 2024

Hopefully this will prevent future dependabots PR to fail and same for contributors.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (9edac60) to head (ed9f5d8).
Report is 1 commits behind head on master.

Additional details and impacted files

Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not convinced there's any benefit to making dependabot weekly - they're rarely that frequent, so we'll just learn about problems later?

@d7415
Copy link
Contributor

d7415 commented Oct 28, 2024

Ok, I see a lot today. But weekly probably means the same number of PRs but concentrated into one day a week.

I mostly see this as "eek, that's a lot of dependencies"

@ildyria ildyria merged commit eb447a1 into master Oct 29, 2024
50 checks passed
@ildyria ildyria deleted the fix-snq branch October 29, 2024 07:58
@ildyria
Copy link
Member Author

ildyria commented Oct 29, 2024

Ok, I see a lot today. But weekly probably means the same number of PRs but concentrated into one day a week.

I mostly see this as "eek, that's a lot of dependencies"

I wish some of those PR were compacted in a single one.

@d7415
Copy link
Contributor

d7415 commented Oct 29, 2024

Definitely. This may be worth a look https://www.hrvey.com/blog/combine-dependabot-prs

Oh, it looks like that schedule doesn't change security PRs, so I retract my comment.

aSouchereau pushed a commit that referenced this pull request Nov 9, 2024
* disable snq if secret is not set
* dependabots less spammy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants