-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Low Quality Image Placeholder cont. #2661
Conversation
@aSouchereau can you squash the full branch ? So that you get all the credits when we merge. :) |
1f84406
to
f7fc2c5
Compare
Oops, not sure if thats correct. All commits related to the placeholder feature are squashed. Everything else is the result of a previous merge commit. |
I fixed the conflicts. |
If so you can squash everything with : # Do make sure that your master branch is up to date with current lychee master
git pull master
# soft reset the branch to master (keep the changes but place the pointer on master HEAD)
git reset --soft master
git commit -m " .... "
git push --force <origin> album-cover-placeholder |
60af2d3
to
757cefe
Compare
Yes, looks good. Thanks for the help :) |
I replaced the |
Continues #2558 for #2258 including new frontend implementation.
Adds low quality image placeholder to be displayed while album covers are downloading.
Improves perceived loading times.
Approach:
Demo