Implements enhancement ideas in #2924 and #2925 and fixes #2925 #2927
+117
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a feature which allows videos to finish playing before moving on the next image or video in the slideshow.
* Added functionality to previous function that allows the video to play till the end before moving to next photo/video with a delay and slideshow interval. * Refactored the code * Added some documentation
…ancsin/Lychee into video_waiting_finish_slideshow
ildyria
reviewed
Jan 18, 2025
ildyria
reviewed
Jan 18, 2025
ildyria
reviewed
Jan 18, 2025
ildyria
reviewed
Jan 18, 2025
|
Thank you for your PR, looks quite good to me already. :) |
Co-authored-by: Benoît Viguier <[email protected]>
Co-authored-by: Benoît Viguier <[email protected]>
Co-authored-by: Benoît Viguier <[email protected]>
Thanks yourself for the review. The pleasure is all mine for allowing me to contribute to this great software. |
ildyria
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enhancements #2924 and #2925 make the user experience better in slideshow mode in the following ways:
The fix #2925 makes the user experience better by allowing the user to stop slideshow immediately when user presses the Escape button on a keyboard.