Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the delete button text #2977

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

RustyPotato
Copy link
Contributor

This will fix the text shown on the delete button when deleting a photo.

This doesn't have an existing issue item. Would you like me to create one?

This fixes the issue by properly referencing dialogs (variable) instead of dialog (undefined).

  • Add a test that triggered the bug before fixing it.
    I wasn't able to find any tests that would address .vue files (like the one edited here). If you could point me in the right direction though, I'd be happy to add one.

Before: As seen on test site (link)
firefox_je37oCr87g

After:
firefox_DKpzGCW6ei

@RustyPotato RustyPotato requested a review from a team as a code owner January 31, 2025 06:29
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (cdc3850) to head (55a8e93).
Report is 27 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit a6d7c12 into LycheeOrg:master Jan 31, 2025
34 checks passed
@RustyPotato RustyPotato deleted the fixDeleteText branch January 31, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants