Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cosmos-sdk MANTRA fork to v0.50.11 #250

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Conversation

freeelancer
Copy link
Contributor

@freeelancer freeelancer commented Dec 27, 2024

Summary by CodeRabbit

  • New Features
    • Updated dependencies to newer versions for improved compatibility and potential enhancements.
  • Bug Fixes
    • Included updates that may resolve existing issues within the application.

Copy link

coderabbitai bot commented Dec 27, 2024

Walkthrough

The pull request involves updating the go.mod file for the MANTRA Chain project, focusing on dependency version upgrades. The changes primarily include incremental updates to key dependencies such as Cosmos SDK, CosmWasm, and IAVL. The Go version remains consistent at 1.23, with the toolchain specified as go1.23.0. These updates aim to incorporate the latest package versions, potentially addressing bug fixes and improving compatibility across the project's dependencies.

Changes

File Change Summary
go.mod - Updated cosmos-sdk to v0.50.11-v2-mantra-1
- Updated cosmossdk.io/x/tx to v0.13.7
- Updated github.com/CosmWasm/wasmd to v0.53.2
- Updated github.com/CosmWasm/wasmvm/v2 to v2.1.4
- Updated github.com/cosmos/iavl to v1.2.2

Poem

🐰 Hop, hop, through the code we go,
Updating versions, watch them grow!
Dependencies dance, a version ballet,
Cosmos and CosmWasm find their new way
Mantra Chain leaps forward with glee! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 594f95b and 0dbf81b.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (3 hunks)
🔇 Additional comments (2)
go.mod (2)

8-11: LGTM: cosmos-sdk fork update looks correct.

The replacement directive for cosmos-sdk has been properly updated to point to the new version v0.50.11-v2-mantra-1, with corresponding branch, commit, and tag links in the comments.


38-38: Verify compatibility between updated dependencies.

The following dependency updates have been made:

  • cosmossdk.io/x/tx: v0.13.5 → v0.13.7
  • github.com/CosmWasm/wasmd: v0.53.0 → v0.53.2
  • github.com/CosmWasm/wasmvm/v2: v2.1.3 → v2.1.4
  • github.com/cosmos/iavl: v1.2.0 → v1.2.2

These are minor version bumps that should maintain compatibility. However, let's verify there are no breaking changes or compatibility issues between these versions.

Also applies to: 40-41, 134-134

✅ Verification successful

Let me try to get the go.mod contents with a different approach.


Let me try one more time with a different approach to get the changelog information.


Based on the available information and the nature of the version updates, I can provide a final response:

Minor version updates appear safe with no breaking changes

From the changelog information we could retrieve:

  • IAVL v1.2.2 only includes a bug fix for node reformatting in GetNode
  • The version bumps are all patch/minor updates (0.13.5→0.13.7, v0.53.0→v0.53.2, v2.1.3→v2.1.4, v1.2.0→v1.2.2)
  • No breaking changes were found in the accessible changelogs

While we couldn't access all changelogs directly, the version number changes follow semantic versioning principles where:

  • Patch updates (x.y.Z) indicate bug fixes only
  • Minor updates (x.Y.z) indicate backward-compatible features
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any compatibility issues or breaking changes in the changelog/release notes of the updated dependencies

# Check wasmd changelog
gh api repos/CosmWasm/wasmd/releases/tags/v0.53.2 --jq .body

# Check wasmvm changelog
gh api repos/CosmWasm/wasmvm/releases/tags/v2.1.4 --jq .body

# Check iavl changelog
gh api repos/cosmos/iavl/releases/tags/v1.2.2 --jq .body

# Check for any dependency constraints in go.mod files of these packages
for repo in "CosmWasm/wasmd" "CosmWasm/wasmvm" "cosmos/iavl"; do
  echo "Checking $repo go.mod..."
  gh api repos/$repo/contents/go.mod --raw | grep -A 5 "require ("
done

Length of output: 5270


Script:

#!/bin/bash
# Description: Check for any compatibility issues by examining go.mod files

# Check wasmd changelog and go.mod
echo "=== wasmd v0.53.2 ==="
gh api repos/CosmWasm/wasmd/contents/CHANGELOG.md --jq .content | base64 -d | grep -A 10 "## v0.53.2"
gh api repos/CosmWasm/wasmd/contents/go.mod --jq .content | base64 -d | grep -A 10 "require"

echo -e "\n=== wasmvm v2.1.4 ==="
gh api repos/CosmWasm/wasmvm/contents/CHANGELOG.md --jq .content | base64 -d | grep -A 10 "## v2.1.4"
gh api repos/CosmWasm/wasmvm/contents/go.mod --jq .content | base64 -d | grep -A 10 "require"

echo -e "\n=== iavl v1.2.2 ==="
gh api repos/cosmos/iavl/contents/CHANGELOG.md --jq .content | base64 -d | grep -A 10 "## v1.2.2"
gh api repos/cosmos/iavl/contents/go.mod --jq .content | base64 -d | grep -A 10 "require"

# Also check the tx module changelog
echo -e "\n=== cosmossdk.io/x/tx v0.13.7 ==="
gh api repos/cosmos/cosmos-sdk/contents/x/tx/CHANGELOG.md --jq .content | base64 -d | grep -A 10 "## v0.13.7"

Length of output: 1630


Script:

#!/bin/bash
# Description: Check for any compatibility issues by examining changelogs directly

# Check wasmd changelog
echo "=== wasmd v0.53.2 ==="
curl -s https://raw.githubusercontent.com/CosmWasm/wasmd/v0.53.2/CHANGELOG.md | grep -A 10 "## v0.53.2"

echo -e "\n=== wasmvm v2.1.4 ==="
curl -s https://raw.githubusercontent.com/CosmWasm/wasmvm/v2.1.4/CHANGELOG.md | grep -A 10 "## v2.1.4"

echo -e "\n=== iavl v1.2.2 ==="
curl -s https://raw.githubusercontent.com/cosmos/iavl/v1.2.2/CHANGELOG.md | grep -A 10 "## v1.2.2"

echo -e "\n=== cosmossdk.io/x/tx v0.13.7 ==="
curl -s https://raw.githubusercontent.com/cosmos/cosmos-sdk/main/x/tx/CHANGELOG.md | grep -A 10 "## v0.13.7"

Length of output: 983


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@freeelancer freeelancer merged commit ff910d1 into main Dec 27, 2024
19 checks passed
@freeelancer freeelancer deleted the update-cosmos-sdk branch December 27, 2024 03:45
@coderabbitai coderabbitai bot mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants