8343946: JFR: Wildcard should only work with COUNT for 'jfr view'

Reviewed-by: mgronlun
MBaesken · Nov 12, 2024 · e5eaa7f · e5eaa7f
1 parent 2989d87
commit e5eaa7f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/jdk.jfr/share/classes/jdk/jfr/internal/query/QueryResolver.java b/src/jdk.jfr/share/classes/jdk/jfr/internal/query/QueryResolver.java
@@ -144,7 +144,7 @@ private void resolveSelect() throws QueryException {
             field.aggregator = expression.aggregator();
             FieldBuilder.configureAggregator(field);
             expression.alias().ifPresent(alias -> fieldAliases.put(alias, field));
-            if (field.name.equals("*") && field.aggregator != Aggregator.COUNT) {
+            if (expression.name().equals("*") && field.aggregator != Aggregator.COUNT) {
                 throw new QuerySyntaxException("Wildcard ('*') can only be used with aggregator function COUNT");
             }
         }
@@ -259,7 +259,7 @@ private List<Field> resolveFields(String name, List<FilteredType> types) {
         List<Field> fields = new ArrayList<>();
 
         if (name.equals("*")) {
-            // Used with COUNT(*) and UNIQUE(*)
+            // Used with COUNT(*)
             // All events should have a start time
             name = "startTime";
         }

diff --git a/src/jdk.jfr/share/classes/jdk/jfr/internal/query/view.ini b/src/jdk.jfr/share/classes/jdk/jfr/internal/query/view.ini
@@ -178,7 +178,7 @@ table = "COLUMN 'StackTrace', 'Count', 'Avg.', 'Max.'
 [application.contention-by-address]
 label = "Contention by Monitor Address"
 table = "COLUMN 'Monitor Address', 'Class', 'Threads', 'Max Duration'
-         SELECT address, FIRST(monitorClass), UNIQUE(*), MAX(duration) AS M
+         SELECT address, FIRST(monitorClass), UNIQUE(eventThread), MAX(duration) AS M
          FROM JavaMonitorEnter
          GROUP BY monitorClass ORDER BY M"