Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary GNU 13 Silo Build Fix #447

Merged
merged 1 commit into from
May 31, 2024

Conversation

henryleberre
Copy link
Member

Description

This hotfix gets Silo building on GNU 13. It should also pass the -a test suite. Let's perpetuate the tradition of hacky C code. This fix isn't pretty, but it should be correct, given the types we are working with.

@henryleberre henryleberre requested a review from sbryngelson as a code owner May 30, 2024 17:35
@henryleberre henryleberre linked an issue May 30, 2024 that may be closed by this pull request
@sbryngelson
Copy link
Member

approved so long as it passes CI and builds locally on gcc13+14

@sbryngelson sbryngelson merged commit 9369312 into MFlowCode:master May 31, 2024
14 of 16 checks passed
@sbryngelson sbryngelson deleted the gnu-13-silo-hotfix branch May 31, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Silo doesn't build with gcc version >= 13
2 participants