Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCE 18 on Frontier & Benchmarking fixes among others #596

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

henryleberre
Copy link
Member

Attempting to upstream the bits from #544 that do not hinder performance.

Note: The golden files were NOT regenerated. The coordinates
were just removed from the existing ones using a script.
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.28%. Comparing base (cbbc8ec) to head (92b4cc8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/pre_process/m_data_output.fpp 33.33% 1 Missing and 1 partial ⚠️
src/simulation/m_mpi_proxy.fpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   62.89%   53.28%   -9.61%     
==========================================
  Files          58       58              
  Lines       14700    14150     -550     
  Branches     1861     1729     -132     
==========================================
- Hits         9245     7540    -1705     
- Misses       4856     6097    +1241     
+ Partials      599      513      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson
Copy link
Member

sbryngelson commented Aug 31, 2024

Ugh, waiting on Phoenix GPU nodes. I will look more closely at that this afternoon and see what's up.

Edit: Nevermind, just test suite, seems like things are going fine.

@sbryngelson sbryngelson merged commit cf3ac9f into MFlowCode:master Aug 31, 2024
20 of 22 checks passed
@sbryngelson sbryngelson deleted the chemfc-up-and-down branch August 31, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants