Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated build hacks. Includes move to CCE18 (Frontier) #620

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

henryleberre
Copy link
Member

@henryleberre henryleberre commented Sep 10, 2024

  • Removed CCE 16 workgroup hacks.
  • Removed AppleClang workarounds on macOS, including building MPI from scratch.
  • Only build FFTW and SILO packages if they are not installed/compatible (HDF5 not currently possible).
  • Removed Docker (nobody uses it, and maintaining it is cumbersome).
  • Switched to using the proper Silo patch for an error on GNU 13 and above. See my comment here: Silo does not compile with gcc 14 LLNL/Silo#375 (comment).
  • Removed installation instructions for Arch Linux. They installed their operating system, I'm sure they can install gcc.

Note from @sbryngelson: After this PR, use of <CCE18.0.0 will not be possible. Revert to previous release for use of CCE16.0.1 on Frontier/Tioga/El Capitan.

@henryleberre henryleberre force-pushed the cant-rm-rf-all-em-hacks branch 8 times, most recently from 36cbcf0 to cbf9e56 Compare September 11, 2024 00:41
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.69%. Comparing base (63c79cb) to head (d540220).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #620   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files          59       59           
  Lines       13662    13662           
  Branches     1698     1698           
=======================================
  Hits         7473     7473           
  Misses       5740     5740           
  Partials      449      449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryleberre henryleberre force-pushed the cant-rm-rf-all-em-hacks branch from cbf9e56 to d540220 Compare September 11, 2024 04:53
@sbryngelson
Copy link
Member

Will merge once Phoenix is back up.

@sbryngelson sbryngelson changed the title Remove build hacks that are no longer needed Remove deprecated build hacks. Includes move to CCE18 (Frontier) Sep 13, 2024
@sbryngelson sbryngelson merged commit 2d1de77 into MFlowCode:master Sep 13, 2024
21 checks passed
@sbryngelson sbryngelson deleted the cant-rm-rf-all-em-hacks branch September 13, 2024 12:24
@sbryngelson sbryngelson mentioned this pull request Sep 13, 2024
4 tasks
@ChrisZYJ ChrisZYJ mentioned this pull request Sep 28, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants