fix typos #22
Merged
fix typos #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MFraters
reviewed
Aug 14, 2020
| @@ -113,14 +113,14 @@ namespace aspect | |||
|
|
|||
| /** | |||
| * After cells have been marked for coarsening/refinement, apply | |||
| * additional criteria independent of the error estimate. | |||
| * additional criteria independent of the error estimation. | |||
There was a problem hiding this comment.
I think the original is more correct. Could you revert this change?
| "fields are within the ranges of values given. If these conditions " | ||
| "hold, then an indicator is either put on or taken off " | ||
| "in order to secure mesh refinement within the range of levels " | ||
| "given. Usage of this plugin allows the user to put a conditional " | ||
| "minimum and maximum refinement function onto fields that they " | ||
| "are interested in." | ||
| "\n\n" | ||
| "For now, only temperature and names of compositions are allowed as " | ||
| "For now, only temperature and compositional fields are allowed as " |
There was a problem hiding this comment.
shouldn't we mention that the compositional field is entered by it's name (maybe provide an what the default names look like if no names are provided?)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some typos.