Add topo from file #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…psoid_topo Conflicts: include/aspect/geometry_model/ellipsoidal_chunk.h source/geometry_model/ellipsoidal_chunk.cc
Add value function to uniform grid Clean up Astyle
| for (unsigned int i=0; i<2; i++) | ||
| Assert (endpoints[i].first < endpoints[i].second, | ||
| ExcMessage ("The interval in each coordinate direction needs " | ||
| "to have positive size")); |
There was a problem hiding this comment.
De corner waarden zijn volgens mij niet gegarandeerd positief (coördinaten lopen van -90 tot 90 en -180 tot 180 voor latitude en longitude respectievelijk). Ik moet er nog een keer naar kijken, maar weet je zeker dat er niet het zelfde nodig is als bij de generatie van de coarse grid? En ss deze assert nodig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works for a fantasy data file. Still have to make it pretty.