Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds background to logo #60. #62

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Adds background to logo #60. #62

merged 4 commits into from
Sep 8, 2020

Conversation

Lucas-Mc
Copy link
Collaborator

@Lucas-Mc Lucas-Mc commented Sep 8, 2020

Adds a background to the LCP logo on the main page. This revives the appearance of the logo on the old website. Also fixes the image size to maintain size during adjustment of the window. Fixes part of #60.

Adds a background to the LCP logo on the main page. This revives the appearance of the logo on the old website. Also fixes the image size to maintain size during adjustment of the window. Fixes part of #60.
@tompollard
Copy link
Member

the background color on the LCP logo looks really odd, but i understand that this is just responding to a request.

i don't think the new CSS is doing what you want it to do. e.g.:

Screen Shot 2020-09-08 at 09 36 29

perhaps keep the img-fluid and set a width or min-width on the logo? in general, i think some resizing is good because it can be helpful on phones etc.

@Lucas-Mc
Copy link
Collaborator Author

Lucas-Mc commented Sep 8, 2020

@tompollard This latest commit restrains the image size a bit, but now it appears that the issue is the actual header which can be fixed in another pull request, or here if that's better? Either way, I think this latest commit is an improvement.

@tompollard
Copy link
Member

Well spotted, col-md-0 looks like a typo.

@Lucas-Mc Lucas-Mc merged commit 4b6e62e into dev Sep 8, 2020
@Lucas-Mc Lucas-Mc deleted the logo_background branch September 8, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants