[T-CAIREM 1243] Hotfix issue with boolean conversion and use string comparison instead #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkaczmarek
changed the title
bemoody
requested changes
Jan 14, 2025
…ging for ORCID. [T-CAIREM 1243]
matkaczmarek
force-pushed
the
fix/issue_with_boolean_conversion_orcid
branch
from
6879e30 to
e0e2c18
Compare
Good catch, I casted env variable to bool and it works this time. Thanks for this tip. |
bemoody
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
enable_orcid_loginvariable is passed as string and therefore it is evaluated to true showing orcid log in all the time.