Fix CSS kludge that breaks JavaScript modal boxes #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this instead of changing the dimensions and overflow behavior of the html and body elements, which interferes with external JavaScript packages such as CKEditor and TinyMCE.
|
See also pull #2324. If you're trying to test this, remember that you need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An old kludge by Lucas Bulgarelli (to make the splash-screen fill the browser window) currently interferes with CKEditor modal boxes and will interfere with TinyMCE modal boxes.
For example, open one of your "Project Content" pages, scroll to the bottom and in the CKEditor toolbar, click the "equation" button. The equation editor modal box pops up, as expected - but in the background, "behind" the modal box, the page has scrolled back to the top.
The same problem and worse problems occur with TinyMCE.
I don't know why this is, and don't really care to debug it further. It's likely to be browser-dependent.
But I think the best thing is not to mess around with the dimensions and overflow behavior of the html and body elements. On current browsers, we can use
100vhto get Lucas's desired effect, and it doesn't really hurt anything if the effect doesn't work on outdated browsers.