Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #175. 1. switch conversion issue, 2. static constexpr i… #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions include/kimera-vio/mesh/MeshOptimization.h
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,12 @@ class MeshOptimization {
private:
const MeshOptimizerType mesh_optimizer_type_;

static constexpr bool kUseSpringEnergies = false;
static constexpr float kSpringNoiseSigma = 0.5f;
static constexpr float kDepthMeasNoiseSigma = 0.1f;
static constexpr float kMissingZ = 10000.0f;
static constexpr float kMinZ = 0.00001f;
static constexpr float kMaxZ = 10.0f;
const bool kUseSpringEnergies = false;
const float kSpringNoiseSigma = 0.5f;
const float kDepthMeasNoiseSigma = 0.1f;
const float kMissingZ = 10000.0f;
const float kMinZ = 0.00001f;
const float kMaxZ = 10.0f;

//! Camera with which the noisy point cloud and the 2d mesh were generated.
Camera::ConstPtr mono_camera_;
Expand Down
18 changes: 8 additions & 10 deletions src/backend/VioBackend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -133,21 +133,19 @@ BackendOutput::UniquePtr VioBackend::spinOnce(const BackendInput& input) {
if (VLOG_IS_ON(10)) input.print();

bool backend_status = false;
switch (backend_state_) {
case BackendState::Bootstrap: {
if(backend_state_ == BackendState::Bootstrap)
{
initializeBackend(input);
backend_status = true;
break;
}
case BackendState::Nominal: {
}
else if (backend_state_ == BackendState::Nominal)
{
// Process data with VIO.
backend_status = addVisualInertialStateAndOptimize(input);
break;
}
default: {
}
else
{
LOG(FATAL) << "Unrecognized Backend state.";
break;
}
}

// Fill ouput_payload (it will remain nullptr if the backend_status is not ok)
Expand Down
14 changes: 6 additions & 8 deletions src/frontend/VisionImuFrontend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,15 @@ VisionImuFrontend::~VisionImuFrontend() {

FrontendOutputPacketBase::UniquePtr VisionImuFrontend::spinOnce(
FrontendInputPacketBase::UniquePtr&& input) {
switch (frontend_state_) {
case FrontendState::Bootstrap: {
if (frontend_state_ == FrontendState::Bootstrap) {
return bootstrapSpin(std::move(input));
} break;
case FrontendState::Nominal: {
}
else if (frontend_state_ == FrontendState::Nominal) {
return nominalSpin(std::move(input));
} break;
default: {
}
else {
LOG(FATAL) << "Unrecognized Frontend state.";
} break;
}
}
}

void VisionImuFrontend::outlierRejectionMono(
Expand Down