-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align recipes for cocktails starting with A #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorted the Cocktails, Ingredients, and Instructions JSON alphabetically for easier finding.
I have updated Gin to Cognac in the Alexander recipe as per the IBA recipe here: https://iba-world.com/alexander/ Note that the linked page also states Gin was originally used for this cocktail, but I have swapped it to align with the current IBA recipe.
Updated lime juice to 15ml to better align with most recipes.
Updated instructions to align with other similar instructions.
Minor recipe wording change to try to align with other recipes
Adjusted Amaretto Fizz recipe to better align with other recipes.
Adjusted the instructions to better align with other instructions
Adjusted instructions to better align with other cocktails
Aligned instructions to other instructions, and to better represent to IBA instructions.
Updated the apple highball recipe to have the ginger beer ingredient listed as an ingredient, and also adjusted instructions to align with ingredients.
Updated ingredients to align with other recipes. 70ml + 1 carrot was not going to fill three small cups. All other recipes I found online stated 2 cups of apple juice to one carrot, so I have used the same. Also simplified instructions to align with other recipes.
Updated the recipe to better align with other recipes.
Bumped up the soda water amount. Most recipes I found called for filling the rest of the glass, and one called for 30ml/1oz. Have gone with 30ml for now as this seems to be the minimum you'd want. Adjusted instructions to refer to simple syrup like the ingredient list instead of sugar syrup.
Melon liqueur was listed as a replacement for itself. Fixed.
Minor word change in instructions.
Slight word update
Aligned wording of recipe with other recipes
Align recipe with other instructions
Thank you! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started reviewing all the recipes and trying to align them with each other, make sure they matched the recipe, and tried to avoid having recipes as a direct copy from another source and instead paraphrase. There are lots of cocktails so I've only made it through the ones starting with A so far 😆
There were some merge conflicts from other changes, I'm not a git expert so if there's something I'm supposed to do to make it merge nicer then let me know, but I think it's ok now.
Each update to a recipe is in a commit, with each commit description having more specific information about what was changed. Most are just some minor wording changes, but there are a small number with changes to ingredients.
Plus melon liqueur was listed as it's own replacement so I fixed that 😆