Skip to content

Commit

Permalink
Merge branch 'mp_thompson_cldfra' into hotfix-v8.0.2 (PR #1153)
Browse files Browse the repository at this point in the history
This merge fixes a bug when calling the Thompson parameterization of the cloud
fraction. The input to the Thompson scheme expects the grid scale to be in units
of km, but in the mpas_atmphys_driver_cloudiness module, dx_p was in units of
meters. The unit of dx_p has been corrected to be in kilometers.

Acknowledgements: Thanks to Brett Wilt for first identifying the bug in the
units of dx_p in the call to the Thompson cloud fraction scheme.

* mp_thompson_cldfra:
  * In ./src/core_atmosphere/physics/mpas_atmphys_driver_cloudiness.F, corrected the units of   the variable dx_p from meters to kilometers (dx_p is used in the Thompson parameterization   of the cloud fraction).
  • Loading branch information
mgduda committed Mar 25, 2024
2 parents 098e9c2 + 9e1e1b4 commit 3f6d870
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/core_atmosphere/physics/mpas_atmphys_driver_cloudiness.F
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ module mpas_atmphys_driver_cloudiness
! Laura D. Fowler ([email protected]) / 2016-07-05.
! * since we removed the local variable radt_cld_scheme from mpas_atmphys_vars.F, now defines radt_cld_scheme
! as a pointer to config_radt_cld_scheme.
! Laura D. Fowler ([email protected]) / 2917-02-16.
! Laura D. Fowler ([email protected]) / 2017-02-16.
! * this is a bug fix. dx_p is converted from meters to kilometers prior to calling the thompson parameterization
! of the cloud fraction.
! Laura D. Fowler ([email protected]) / 2024-03-23.


contains
Expand Down Expand Up @@ -119,6 +122,8 @@ subroutine cloudiness_from_MPAS(configs,mesh,diag_physics,sfc_input,its,ite)
do j = jts,jte
do i = its,ite
dx_p(i,j) = len_disp / meshDensity(i)**0.25
!conversion of dx_p from meters to kilometers.
dx_p(i,j) = dx_p(i,j)*0.001
xland_p(i,j) = xland(i)
enddo

Expand Down

0 comments on commit 3f6d870

Please sign in to comment.