Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ISPOL 1D testcase #15

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

njeffery
Copy link

@njeffery njeffery commented Nov 9, 2022

Atmospheric, ocean and biogeochemical data from the 2004 Ice Station Polarstern (ISPOL) Weddell Sea (67.9S, 54W) from June 16, 2004 to December 31, 2004.

BFB in all other test cases

Atmospheric, ocean and biogeochemical data from the 2004 Ice Station Polarstern (ISPOL)
Weddell Sea (67.9S, 54W) from June 16, 2004 to December 31, 2004.

BFB in all other test cases
@njeffery
Copy link
Author

njeffery commented Nov 9, 2022

@akturner : This is the E3SM PR that's needed for the above testcase:
E3SM-Project/E3SM#5282

@njeffery njeffery requested a review from akturner November 9, 2022 17:02
@njeffery njeffery added the enhancement New feature or request label Nov 9, 2022
@njeffery njeffery self-assigned this Nov 9, 2022
@njeffery njeffery requested a review from eclare108213 November 9, 2022 17:04
@njeffery
Copy link
Author

njeffery commented Nov 9, 2022

@akturner : the last two commits corrected bugs in the forcing plot script. It should all work now.

@@ -0,0 +1,24 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases dont have batch scripts associated with them, especially ones with person specific info. Remove from repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the job_script.


def run_testcase():

MPAS_SEAICE_EXECUTABLE = os.environ.get('MPAS_SEAICE_EXECUTABLE')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MPAS_SEAICE_TESTCASES_RUN_COMMAND = os.environ.get('MPAS_SEAICE_TESTCASES_RUN_COMMAND')
if (MPAS_SEAICE_TESTCASES_RUN_COMMAND is None):
MPAS_SEAICE_TESTCASES_RUN_COMMAND = ""
MPAS_SEAICE_DOMAINS_DIR = os.environ.get('MPAS_SEAICE_DOMAINS_DIR')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,22 @@
# Set DOMAINS DIRECTORY for ISPOL (67.9 S, -54.4 E)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specific to anvil so please remove the README

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants