Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024.7.2] 30/07/2024 #3495

Merged
merged 126 commits into from
Jul 30, 2024
Merged

[2024.7.2] 30/07/2024 #3495

merged 126 commits into from
Jul 30, 2024

Conversation

Riron
Copy link
Collaborator

@Riron Riron commented Jul 30, 2024

🚀 Nouvelles fonctionnalités

  • ETQ utilisateur, je peux faire du multi-modal sur le BSFF PR #3421

🏠 Interne

  • Refacto de la validation BSVHU PR 3477

💅 Améliorations

  • ETQ utilisateur, je peux préciser la quantité refusée lors de la réception d'un BSDD PR 3252, PR 3418
  • Ajout de la date et de l'heure d'édition dans les PDFs PR 3452
  • Suppression de colonnes dépréciées dans les registres (champ libre transporteur, expéditeur & destination, date de cession & d'acquisition, producteurs initiaux codes postaux, producteur initial (regitres de transport & gestion), plaques d'immatriculations (tous les registres sauf transport & exhaustif)) PR 3446
  • Ajout des noms usuels de l'expéditeur, des transporteurs ainsi que de la destination sur le registre exhaustif PR 3464
  • Séparation des adresses des registres en 4 champs: Libellé, Code postal, Commune, Pays PR 3456

Riron and others added 30 commits June 5, 2024 20:51
…ur prévenir les utilisateurs que l'information sera accessible pour d'autres acteurs (#3381)
…it être retourné par la requête companyInfos même pour des entreprises non-diffusibles (#3399)
… négociant & courtier dans tous les registres (#3392)

* feat: BSDD

* feat: other BSDs

* fix: lint
[TRA-14407] Page blanche lorsque je souhaite "Mettre à jour le bordereau pour le publier" sur un PAOH
[tra-14435] Revoir les messages d'erreur à l'ajout d'un Crématorium non inscrit / n'ayant pas le bon profil
add tests for bsff parsing

fix createBsff.integration.ts and updateBsff.integration.ys

move bsff validation into its own file

implement bsffPackagingValidation

add test for bsffPackaging validation

updateBsffPackaging with zod validation

fix integration tests

fix sonarcloud warnings

try to reduce duplication score

refactor duplicates line

fix linting

add documentation for zod validation

update changelog

handle parsing in signBsff and publishBsff

fix tests
[tra-14414] Refacto de la validation BSFF
…tination post-entreposage provisoire sur le registre sortant et exhaustif (#3349)

* feat: started implementing feature. tests needed

* feat: added integration tests

* feat: improved comments

* fix: reverted unwanted change

* fix: fixed integration test

* fix: fixed address edge-case

* feat: added BSDA

* lint

* lint

* feat: added country (always FR)
Revoir la taille de la modale en 1099px
…s sur le registre exhaustif (#3367)

* feat: implemented intermediaries for the BSDD

* test: added tests

* refactoring

* test: added test

* feat: added BSDA

* lint

* fix: fixed test
…ensemble des registres (#3409)

* feat(Registry): add fields to registries

* fix(Docs): move TransportMode enum to fix docs generation

* docs(Changelog): update Changelog

* test(BSDD): fix bsdd compat test

* test(BSDD): fix bsdd compat test
…3410)

* feat(Registry): add parcel infos to registries

* docs(Changelog): update Changelog

* fix(Registry): change parcel registry property names to plural

* docs(Registry docs): enrich parcel registry docs

* fix(Registry): fix after rebase
…a liste de membres (page entreprise + TD Admin) (#3384)

* feat(CompanyMembers): make it possible to change a user role on the company admin page

* fix(CompanyMembers): properly update members list when filtered

* feat(MembersAdmin): Add company members admin page

* fix(Companies database): fix companies database test

* refacto(Permissions): refacto admin or permissions check

* test(Company members mutations): add tests to inviteUser/removeUser/resendInvitation/deleteInvitation and create tests for changeUserRole

* docs(Changelog): update Changelog

* style(CompanyMembersList): add padding on company members list

* fix(changeUserRole): modify changeUserRole to make it more readable and not have try/catch sink.
create CompanyMember mapping functions
add some tests

* fix(changeUserRole): various fixes
* fix(updateAppendix2Forms): make updateAppendix2Forms recursive to propagate updates properly

* docs(Changelog): update Changelog
* Enhance logger

* Fix test

* Handle mounted usecase

* Use randomUUID()

* Use originalUrl
benoitguigal and others added 27 commits July 23, 2024 16:19
Registre - corrections et améliorations relatives aux informations de traitement final
* Change format placeholders

* Fix test
* feat: added quantityRefused to model Form

* feat: continuing implementation. Added quantityRefused to GQL resolver + tests

* feat: implemented validation. Removing some constraints on quantityReceived

* feat: fixes in the tests & legacy management

* feat: added variables to the registry

* fix: fixing integration tests

* fix: fixing tests

* feat: added fields to BSDD PDF

* feat: endpoint markAsAccepted

* fix: micro fixes

* fix: lint

* feat: wording (registry & PDF)

* fix: fixed test

* feat: temp storage

* fix: lint

* feat: annexe 2

* fix: removed .only

* feat: more tests & fixes for annexe 2

* fix: micro fix in annexe2 PDF

* feat: bsddRevisionRequest with quantityRefused

* fix: lint

* feat: added migration for revision requests

* fix: removing comments

* fix: fixed PDFs

* fix: emails

* fix: fixed refusal emails subjects

* fix: fixed bsda & paoh refusal mails

* fix: fixed email labels in tests

* fix: fixed integration tests

* [tra-14474] Ajouter la Quantité refusée et la Quantité traitée sur l'Aperçu des différents BSDD (#3389)

* feat: new registry columns

* feat: implemented registry for BSDD

* feat: implemented registry for BSDA

* feat: implemented registry for BSFF

* feat: did registry for BSDASRI

* feat: did registry for BSVHU

* feat: did registry for BSPAOH

* lint

* fix: fixed columns test

* lint

* fix: rollbacked unwanted changes

* fix: removed log

* Changes annexe 2 wording (#3387)

* fix: fixing tests

* merge

* fix: fixed type

* fix: fixed integration tests

* fix: micro fixes

* fix: changed 'Non renseigné' to 'Non reseignée'

* feat: added quantityRefused to markAsTempStoredAccepted mutation

* fix: fixing BE converter that didn't include quantityRefused

* test: added a test on revision requests

* fix: lint

* fix: fixed integration test

---------

Co-authored-by: JulianaJM <[email protected]>
Co-authored-by: Julien Seren-Rosso <[email protected]>
* add basis for partial dump script

* feat(scripts): create partial dump script

* feat(scripts): finish partial dump script

* docs(CONTRIBUTING): add documentation to contributing.md

* fix(scripts): limit traversal through company to users

* fix(partial-backup): catch db errors and cleanup comments

* fix(scripts): limit traversal through MembershipRequest

* fix(Partial Dump): small fixes after review
* feat(BSVHU): create BSVHU zod validation schema

* feat(BSVHU): add rules and refinements to the valdation

* feat(BSVHU): finish validation methods

* use new validation in resolvers

* fix(BSVHU): pass missing weightValue in prisma->zod

* feat(BSVHU): add validation tests, fix various issues, enrich some validation errors with company role

* docs|feat|fix|perf|refactor|revert|style|test(scope1,scope2): centralize sirenify/recipify/validation tests into new validation tests, modify resolver tests and some small fixes

* feat(BSDA/BSFF/BSVHU/BSPAOH): add context to siret/vat schema errors

* feat(BSVHU): remove now useless validation files

* test(BSFF/BSVHU): fix some tests

* test(BSFF): fix bsffpackaging test

* test(BSVHU): fix e2e test

* test(BSVHU): fix typo in tests

* fix(e2e): fix date formatting in tests

* fix(e2e): normalize date locales

* docs(Changelog): update changelog
* feat: added quantityRefused to model Form

* feat: continuing implementation. Added quantityRefused to GQL resolver + tests

* feat: implemented validation. Removing some constraints on quantityReceived

* feat: fixes in the tests & legacy management

* feat: added variables to the registry

* fix: fixing integration tests

* fix: fixing tests

* feat: added fields to BSDD PDF

* feat: endpoint markAsAccepted

* fix: micro fixes

* fix: lint

* feat: wording (registry & PDF)

* fix: fixed test

* feat: temp storage

* fix: lint

* feat: annexe 2

* fix: removed .only

* feat: more tests & fixes for annexe 2

* fix: micro fix in annexe2 PDF

* feat: bsddRevisionRequest with quantityRefused

* fix: lint

* feat: added migration for revision requests

* fix: removing comments

* fix: fixed PDFs

* fix: emails

* fix: fixed refusal emails subjects

* fix: fixed bsda & paoh refusal mails

* fix: fixed email labels in tests

* fix: fixed integration tests

* [tra-14474] Ajouter la Quantité refusée et la Quantité traitée sur l'Aperçu des différents BSDD (#3389)

* feat: new registry columns

* feat: implemented registry for BSDD

* feat: implemented registry for BSDA

* feat: implemented registry for BSFF

* feat: did registry for BSDASRI

* feat: did registry for BSVHU

* feat: did registry for BSPAOH

* lint

* fix: fixed columns test

* lint

* fix: rollbacked unwanted changes

* fix: removed log

* Changes annexe 2 wording (#3387)

* fix: fixing tests

* merge

* fix: fixed type

* fix: fixed integration tests

* Adds reception and acceptation V2 modals

* fix: micro fixes

* fix: rounding kilos tooltips

* fix: fixed rounding in acceptedWeight input + disabling buttons on loading

* fix: not showing error message on refusedWeight when selecting PARTIALLY_REFUSED

* fix: displaying correct values for quantityRefused & quantityAccepted even if 0

* fix: removed console.log

* fix: changed 'Non renseigné' to 'Non reseignée'

* fix: changed 'Non renseigné' to 'Non renseignée'

* fix: fixed weight & isEstimated display

* fix: fixed displayed quantity in Annex2 form

* feat: added quantityRefused to markAsTempStoredAccepted mutation

* fix: tmpStorage reception and acceptation can be done in 2 steps + fixed BsdDetailsContent display

* fix: fixing BE converter that didn't include quantityRefused

* test: added a test on revision requests

* fix: lint

* fix: fixed integration test

* fix: fixed cancel button that triggerd on press Enter

* refacto: PR review comments. Moved files & fixed imports

* fix: fixed test

* fix: fixed imports

* fix: fixed imports

* fix: fixed imports

---------

Co-authored-by: GaelFerrand <[email protected]>
Co-authored-by: GaelFerrand <[email protected]>
Co-authored-by: JulianaJM <[email protected]>
…é, Code postal, Commune, Pays (#3456)

* feat: refactored & improved extractPostalCodes & splitAddress to work with foreign addresses

* feat: implemented fallback for address with no discernable postal code

* feat: implemented initialEmitter

* feat: added splitted addresses for transporters

* fix: fixing types

* fix: fixing tests

* feat: added destination splitted address

* feat: added worker splitted address

* feat: added emitterPickupSite

* feat: added emitter's splitted adress

* fix: fixing columns.test.ts

* fix: removing duplicate fields

* fix: fixed type error

* fix: fixing tests
* Init admin bsd feature

* Fix tests & lint

* Rename query & component

* Rename test
…ainsi que de la destination sur le registre exhaustif (#3464)

* feat: started implementation

* test: added tests

* refacto: improved code

* doc: added comment

* refacto: made code clearer
* fix: fixing display quantityAccepted even if 0 + wording (back)

* fix: fixing decimal issue in refusal email

* fix: removed front duplicate + wording

* fix: adding spaces in mails

* fix: lint

* fix: fixed test
* fix: fixing reception after tmp storage

* fix: fixing stateSummary to feature most up-to-date quantity

* fix: fixing converter

* fix: after tmp_storage, wasteDetailsQuantity is acceptedQuantity, not received

* fix: removed console.log

* fix: fixed markAsReceived. No longer bugging on mail sending

* fix: removing console.log

* fix: mail now displaying correct waste infos for final destination

* fix: fixed jest mocks
* feat: added quantityType to stateSummary

* fix: fixed markAsAccepted, not sending mails if no need

* fix: fixed integration test
* Fixes for quantity received

* Fixes preview conditional rendering

* Fixes form waste summary
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Riron Riron merged commit 44d4eee into master Jul 30, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants