Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

Add aarch64 wheels #12

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Add aarch64 wheels #12

merged 2 commits into from
Jun 25, 2021

Conversation

mattsplats
Copy link
Contributor

@mattsplats mattsplats commented Oct 8, 2020

Working build: https://travis-ci.com/github/mattsplats/h5py-wheels/builds/188922579

Related: #11

Notes:

  • multibuild was updated for proper aarch64 support
  • numpy <1.19 does not contain an aarch64 wheels, could potentially update this to speed things up

@mattsplats
Copy link
Contributor Author

Looks like the repo needs to be migrated from travis-ci.org to travis-ci.com: https://docs.travis-ci.com/user/migrate/open-source-repository-migration

- PLAT=aarch64
- DOCKER_TEST_IMAGE=multibuild/xenial_arm64v8
- os: linux
arch: arm64-graviton2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the build pass if you use the regular travis arm64 machines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no: https://travis-ci.org/github/MacPython/h5py-wheels/builds/735063598

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattip You could try changing the no-output timeout and re-running it.

@odidev
Copy link

odidev commented Oct 15, 2020

@mattsplats , I pulled your changes and ran travis locally, the build was running successfully. Although it was taking around 30-35 minutes, the reason behind this is that it is taking time to build numpy as we are using older versions. numpy wheels for aarch64 are present from 1.19.0 version on wards.

Following actions can be taken here:

  1. The issue looks to be sporadic, you can try to re trigger the build.
  2. Update the numpy version which will help to reduce the travis build time.

@mattsplats
Copy link
Contributor Author

Thanks @mattip - I updated numpy versions just for aarch64 for now. Let's see how this run goes.

Wasn't sure if there was a reason the older versions were being used, not having the wheel hasn't been an issue on the Graviton instances since it only takes ~5-10 minutes to compile.

@mattsplats
Copy link
Contributor Author

Still timing out on No output has been received in the last 10m0s, even with Netty 1.19.2. Different config for your local run?

Is there a blocker for migrating from travis-ci.org to travis-ci.com?

@mattip
Copy link

mattip commented Oct 16, 2020

Is there a blocker for migrating from travis-ci.org to travis-ci.com?

I could do it as an admin of MacPython, if the maintainers of this repo agree.

@odidev
Copy link

odidev commented Oct 30, 2020

@matthew-brett, @tacaswell could you please let us know your interest on migrating from travis-ci.org to travis-ci.com?

@mattip
Copy link

mattip commented Oct 30, 2020

Close/reopen to sue use travis-ci.com

Edit: typo

@mattip mattip closed this Oct 30, 2020
@mattip mattip reopened this Oct 30, 2020
@mattsplats mattsplats force-pushed the aarch64 branch 2 times, most recently from 0709ab1 to 1973aa6 Compare October 30, 2020 15:15
@mattsplats
Copy link
Contributor Author

@mattip Thanks! Seems to be working now. I added a commit for Python 3.9 wheels as well.

@AGSaidi
Copy link

AGSaidi commented Jun 23, 2021

@mattip any other changes you'd like to see for this PR? It would be great to have h5py wheels.

@mattip
Copy link

mattip commented Jun 24, 2021

I am not sure who the actual maintainers are of this repo. I see @matthew-brett, @tacaswell and @ngoldbaum have merged PRs in the past, so perhaps they could take a look at this

@tacaswell
Copy link
Contributor

I can merge this, but we have moved away from using this to build the wheels to cibuildwheel on GH actions.

I have also lost track of where this will upload wheels too once they are built.

attn @takluyver who is the release manager for the recent releases.

@tacaswell tacaswell merged commit 02d42a7 into MacPython:master Jun 25, 2021
@takluyver
Copy link

The advantage of having wheels built by our regular CI is that we know the process of building wheels is working before we actually do a release, so we're unlikely to need a last minute scramble to update the build infrastructure.

On the other hand, we've already got a lot of CI machinery (testing with various Python, HDF5 and NumPy versions, plus different platforms), and I don't particularly want to make that even heavier with more architectures. So maybe having the x64 wheels built in the project and other architectures here is a decent compromise.

Where do the wheels from this go? The README points to http://wheels.scipy.org/ and https://3f23b170c54c2533c070-1c8a9b3114517dc5fe17b7c3f8c63a43.ssl.cf2.rackcdn.com/ , but both of those give me errors.

@mattip
Copy link

mattip commented Jun 26, 2021

The upload url on rackcdn has been dead for a while, it was mirrored as http://wheels.scipy.org.

If your regular CI is using cibuildwheel, then I think moving only the non-x86 builds to use cibuildwheel on travis would by your best bet. Instructions to do that are here.

[W]e have moved away from using this to build the wheels to cibuildwheel on GH actions

I looked around a bit on https://github.com/h5py/h5py for github actions, but found only an azure pipelines CI job. Is that what you meant? In any case, the artifact upload will need to be added to the typical cibuildwheel travis skeleton I linked to above.

@tacaswell
Copy link
Contributor

Is that what you meant? In any case, the artifact upload will need to be added to the typical cibuildwheel travis skeleton I linked to above.

Yes, sorry I I was confused about where we landed 🐑 . The important point is we are not relying on this repo any longer for the x86 wheels.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants