Improved handling of class tokens #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed method of ReplicaService.ReturnClassToken as a way of checking whether a ClassToken already exists Proposed clearing class token names when replicas are destroyed, because class tokens are supposed to be unique to the replica and the token is not used when the replica is destroyed (Context: use case that inspired this was a project where replicas are assigned to the player when they join ex: ClassToken = ReplicaService.NewClassToken(Replica_[playername])" and when they leave the replica is destroyed. If the player rejoins the game, an error occurs, because the class token already exists. Two proposed methods, one to check if a class token exists by retrieving it and the other to remove class tokens from internal table when replicas are destroyed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed method of ReplicaService.ReturnClassToken as a way of checking whether a ClassToken already exists
Proposed clearing class token names when replicas are destroyed, because class tokens are supposed to be unique to the replica and the token is not used when the replica is destroyed
(Context: use case that inspired this was a project where replicas are assigned to the player when they join ex: ClassToken = ReplicaService.NewClassToken(Replica_[playername])" and when they leave the replica is destroyed. If the player rejoins the game, an error occurs, because the class token already exists. Two proposed methods, one to check if a class token exists by retrieving it and the other to remove class tokens from internal table when replicas are destroyed)