Stairs

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## v0.8.13 - 2024-10-21
+
+- Added aesthetics for `Stairs` [#573](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/573).
+
 ## v0.8.12 - 2024-10-07
 
 - Added `legend` keyword in `visual` to allow overriding legend element attributes [#570](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/570).

Project.toml

@@ -1,7 +1,7 @@
 name = "AlgebraOfGraphics"
 uuid = "cbdf2221-f076-402e-a563-3d30da359d67"
 authors = ["Pietro Vertechi", "Julius Krumbiegel"]
-version = "0.8.12"
+version = "0.8.13"
 
 [deps]
 Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"

src/aesthetics.jl

@@ -451,3 +451,14 @@ function aesthetic_mapping(::Type{Hist}, ::Normal)
         :strokecolor => AesColor,
     ])
 end
+
+aesthetic_mapping(::Type{Stairs}, ::Normal) = aesthetic_mapping(Stairs, 1)
+aesthetic_mapping(::Type{Stairs}, ::Normal, ::Normal) = aesthetic_mapping(Stairs, 2)
+
+function aesthetic_mapping(::Type{Stairs}, N::Int)
+    dictionary([
+        pointlike_positionals(N)...,
+        :color => AesColor,
+        :linestyle => AesLineStyle,
+    ])
+end

src/guides/legend.jl

@@ -384,7 +384,7 @@ function legend_elements(T::Type{Heatmap}, attributes, scale_args::MixedArgument
     )]
 end
 
-function legend_elements(T::Type{<:Union{HLines,VLines,Lines,LineSegments,Errorbars,Rangebars,Wireframe,ABLines,ECDFPlot}}, attributes, scale_args::MixedArguments)
+function legend_elements(T::Type{<:Union{HLines,VLines,Lines,LineSegments,Errorbars,Rangebars,Wireframe,ABLines,ECDFPlot,Stairs}}, attributes, scale_args::MixedArguments)
 
     is_vertical = T === VLines || (T <: Union{Errorbars,Rangebars} && _get(T, scale_args, attributes, :direction) === :y)
     # TODO: seems errorbars and rangebars are missing linestyle in Makie, once this is fixed, remove this

test/reference_tests.jl

@@ -1007,3 +1007,14 @@ reftest("legend element overrides") do
         visual(Scatter, legend = (; markersize = 30))
     draw(spec)
 end
+
+reftest("stairs") do
+    spec = mapping(
+        1:10,
+        [1, 4, 3, 7, 5, 3, 2, 4, 3, 7],
+        color = repeat(["A", "B"], inner = 5),
+        linestyle = repeat(["A", "B"], inner = 5),
+    ) *
+        visual(Stairs)
+    draw(spec)
+end