Fix recipe docs #1448
Fix recipe docs #1448
Conversation
| `argument_names(::Type{<: MyPlot}) = (:x, :y, :z)` | ||
| ```julia | ||
| argument_names(::Type{<: MyPlot}) = (:x, :y, :z) | ||
| ``` | ||
|
|
||
| This is optional but it will allow the use of `plot_object[:x]` to |
There was a problem hiding this comment.
Later on in the stocks example, the arguments are fetched like plot_object.x. Is both supported or should the above be changed to match the example?
There was a problem hiding this comment.
I prefer plot.x and would like to deprecate plot[:x] at some point, or change its meaning...
There was a problem hiding this comment.
Should I change this in the docs to bridge the gap while you are working on the overhaul? I couldn't find where plot.x get's wired into getproperty, so I didn't feel comfortable doing the change right away. Here are some other occurences:
There was a problem hiding this comment.
Sorry, somehow missed your comment... Yeah I think that's a good idea!
And then getproperty uses getindex here:
https://github.com/JuliaPlots/Makie.jl/blob/78820311c9b45347f0937caf8b31a25bbc27dd73/MakieCore/src/attributes.jl#L83
(Not very straightforward to find, especially with the Transformable supertype)
|
Just found out about #771 and friends. So maybe this isn't needed anymore? |
ghost
deleted a comment
No description provided.