[#124] refactor: PostContent 업데이트 메서드 제거 후, 새로운 객체를 통해 업데이트하도록 변경

Mallang-log · Dec 4, 2023 · 87226a9 · 87226a9
1 parent 7e2da6e
commit 87226a9
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 80 deletions.
diff --git a/src/main/java/com/mallang/post/domain/Post.java b/src/main/java/com/mallang/post/domain/Post.java
@@ -82,15 +82,15 @@ public void update(
             List<String> tags
     ) {
         this.visibilityPolish = new PostVisibilityPolicy(visibility, password);
-        this.content.update(title, intro, bodyText, postThumbnailImageName, category, tags);
+        this.content = new PostContent(title, intro, bodyText, postThumbnailImageName, category, tags, getWriter());
     }
 
     public void delete() {
         registerEvent(new PostDeleteEvent(getId()));
     }
 
     public void removeCategory() {
-        this.content.removeCategory();
+        this.content = content.removeCategory();
     }
 
     public void clickLike() {

diff --git a/src/main/java/com/mallang/post/domain/PostContent.java b/src/main/java/com/mallang/post/domain/PostContent.java
@@ -59,26 +59,10 @@ public PostContent(
             Member writer
     ) {
         this.title = title;
-        this.bodyText = bodyText;
-        this.postThumbnailImageName = postThumbnailImageName;
         this.postIntro = new PostIntro(postIntro);
-        this.writer = writer;
-        setCategory(category);
-        setTags(tags);
-    }
-
-    public void update(
-            String title,
-            String postIntro,
-            String bodyText,
-            @Nullable String postThumbnailImageName,
-            @Nullable Category category,
-            List<String> tags
-    ) {
-        this.title = title;
         this.bodyText = bodyText;
         this.postThumbnailImageName = postThumbnailImageName;
-        this.postIntro = new PostIntro(postIntro);
+        this.writer = writer;
         setCategory(category);
         setTags(tags);
     }
@@ -114,8 +98,16 @@ public boolean isWriter(Member member) {
         return writer.equals(member);
     }
 
-    public void removeCategory() {
-        this.category = null;
+    public PostContent removeCategory() {
+        return new PostContent(
+                getTitle(),
+                getPostIntro(),
+                getBodyText(),
+                getPostThumbnailImageName(),
+                null,
+                getTags(),
+                getWriter()
+        );
     }
 
     public String getPostIntro() {

diff --git a/src/main/java/com/mallang/post/domain/draft/Draft.java b/src/main/java/com/mallang/post/domain/draft/Draft.java
@@ -73,11 +73,11 @@ public void update(
             @Nullable Category category,
             List<String> tags
     ) {
-        this.content.update(title, intro, bodyText, postThumbnailImageName, category, tags);
+        this.content = new PostContent(title, intro, bodyText, postThumbnailImageName, category, tags, getWriter());
     }
 
     public void removeCategory() {
-        this.content.removeCategory();
+        this.content = content.removeCategory();
     }
 
     public void validateWriter(Member member) {

diff --git a/src/test/java/com/mallang/post/domain/PostContentTest.java b/src/test/java/com/mallang/post/domain/PostContentTest.java
@@ -12,7 +12,6 @@
 import com.mallang.category.domain.Category;
 import com.mallang.category.exception.NoAuthorityCategoryException;
 import com.mallang.post.exception.DuplicatedTagsInPostException;
-import java.util.Collections;
 import java.util.List;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.DisplayNameGeneration;
@@ -45,10 +44,14 @@ class PostContentTest {
                 .build();
 
         // when
-        postContent.removeCategory();
+        PostContent removeCategory = postContent.removeCategory();
 
         // then
-        assertThat(postContent.getCategory()).isNull();
+        assertThat(removeCategory.getCategory()).isNull();
+        assertThat(removeCategory)
+                .usingRecursiveComparison()
+                .ignoringFields("category")
+                .isEqualTo(postContent);
     }
 
     @Nested
@@ -155,60 +158,6 @@ class 생성_시 {
         }
     }
 
-    @Nested
-    class 수정_시 {
-
-        @Test
-        void 수정에_성공한다() {
-            // given
-            PostContent postContent = PostContent.builder()
-                    .title("제목")
-                    .postIntro("intro")
-                    .bodyText("내용")
-                    .writer(mallang)
-                    .tags(List.of("태그1"))
-                    .build();
-
-            // when
-            postContent.update(
-                    "수정제목",
-                    "수정인트로", "수정내용",
-                    "postThumbnailImageName",
-                    null,
-                    List.of("태그2")
-            );
-
-            // then
-            assertThat(postContent.getTitle()).isEqualTo("수정제목");
-            assertThat(postContent.getBodyText()).isEqualTo("수정내용");
-            assertThat(postContent.getTags())
-                    .containsExactly("태그2");
-        }
-
-        @Test
-        void 다른_사람의_카테고리로_수정_시_예외() {
-            // given
-            PostContent postContent = PostContent.builder()
-                    .title("제목")
-                    .postIntro("intro")
-                    .bodyText("내용")
-                    .writer(mallang)
-                    .tags(List.of("태그1"))
-                    .build();
-
-            // when & then
-            assertThatThrownBy(() -> {
-                postContent.update(
-                        "수정제목",
-                        "수정인트로", "수정내용",
-                        "postThumbnailImageName",
-                        otherCategory,
-                        Collections.emptyList()
-                );
-            }).isInstanceOf(NoAuthorityCategoryException.class);
-        }
-    }
-
     @Test
     void 작성자_확인() {
         // given