Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 댓글에 대한 비밀 대댓글을 댓글 작성자가 볼 수 있도록 변경 #168

Merged
merged 3 commits into from
Dec 14, 2023
Merged

feat: 댓글에 대한 비밀 대댓글을 댓글 작성자가 볼 수 있도록 변경 #168

merged 3 commits into from
Dec 14, 2023

Conversation

shin-mallang
Copy link
Member

@shin-mallang shin-mallang self-assigned this Dec 14, 2023
@shin-mallang shin-mallang linked an issue Dec 14, 2023 that may be closed by this pull request
[🚀 feature] 댓글에 대한 비밀 대댓글을 댓글 작성자가 볼 수 있도록 한다 #167
Closed
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited
Loading

Test Results

317 files   - 1  317 suites   - 1   34s ⏱️ -1s
908 tests +4  907 ✔️ +4  1 💤 ±0  0 ❌ ±0 
943 runs  +4  942 ✔️ +4  1 💤 ±0  0 ❌ ±0 

Results for commit 1348e5e. ± Comparison against base commit 058d7b2.

This pull request removes 20 and adds 11 tests. Note that renamed tests count towards both. 

 
          Shin._.Mallang
        title-value
    </title>
    <meta property="og:title" content="Shin._.Mallang"/>
    <title>
    HI
 </head>
</body>
…

com.mallang.comment.domain.AuthCommentTest$인증된_댓글의_내용을_볼_수_있는_경우는 ‑ 나머지는 볼 수 없다
com.mallang.comment.domain.AuthCommentTest$인증된_댓글의_내용을_볼_수_있는_경우는 ‑ 댓글의 작성자면 볼 수 있다
com.mallang.comment.domain.AuthCommentTest$인증된_댓글의_내용을_볼_수_있는_경우는 ‑ 댓글이 달린 포스트의 작성자면 볼 수 있다
com.mallang.comment.domain.AuthCommentTest$인증된_댓글의_내용을_볼_수_있는_경우는 ‑ 비밀댓글이 아니면 볼 수 있다
com.mallang.comment.domain.AuthCommentTest$인증된_댓글의_내용을_볼_수_있는_경우는 ‑ 해당 댓글이 대댓글인 경우 부모 댓글의 작성자면 볼 수 있다
com.mallang.comment.query.CommentQueryServiceTest$특정_포스트의_댓글_모두_조회_시 ‑ 내가 쓴 댓글에 달린 비밀 대댓글을 볼 수 있다
com.mallang.comment.query.CommentQueryServiceTest$특정_포스트의_댓글_모두_조회_시 ‑ 내가 쓴 비밀 댓글은 볼 수 있다
com.mallang.reference.domain.ReferenceLinkTest$생성_시 ‑ [3] title= 
 
com.mallang.reference.domain.ReferenceLinkTitleTest$생성_시 ‑ [4] title=

com.mallang.reference.infrastructure.jsoup.JsoupUrlTitleMetaInfoFetcherTest ‑ [1] html=<!DOCTYPE html>
<head>
    <title>
          Shin._.Mallang
    </title>
 </head>

<body>
    HI
</body>

</html>

…

♻️ This comment has been updated with latest results.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@shin-mallang shin-mallang merged commit 2d1e32a into main Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shin-mallang shin-mallang

Labels
🎉 오류해결 🚀 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚀 feature] 댓글에 대한 비밀 대댓글을 댓글 작성자가 볼 수 있도록 한다
1 participant
@shin-mallang