[WIP]Refactoring cloud vm retirement email vm_retirement_emails method #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit pkomanek@0844a0d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
suggested changes
Jul 2, 2018
There was a problem hiding this comment.
Please check with @billfitzgerald0120 he has changed all the email methods to be instance based.
pkomanek
changed the title
|
@billfitzgerald0120 Can you confirm this is a deprecated method and we don't have to convert it. |
|
@pkomanek @mkanoor This method is being deprecated in PR https://github.com/ManageIQ/manageiq-content/pull/349/files We should close this one. |
|
@mkanoor I am deprecating this method in PR mentioned above. Can you close it ? |
pkomanek
deleted the
refactoring_cloud_vm_retirement_email_vmRetirementEmails_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Refactoring
Cloud/VM/Retirement/Email.class/__methods__/vm_retirement_emails.rbmethod with adding a new spec. This PR is based on the issue bellow.Links
#8
@miq-bot add_label refactoring