Refactor AE Content Task Finished method and add spec #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregP
changed the title
Pull Request Test Coverage Report for Build 3809
💛 - Coveralls |
GregP
force-pushed
the
state_machine_task_finished-refactoring
branch
from
d5aea24 to
31de2a3
Compare
GregP
force-pushed
the
state_machine_task_finished-refactoring
branch
from
31de2a3 to
9ba87f8
Compare
GregP
changed the title
|
Hi @GregP Can you address the rubocop issue? |
gmcculloug
reviewed
Oct 31, 2019
...te/ManageIQ/System/CommonMethods/StateMachineMethods.class/__methods__/task_finished_spec.rb
Show resolved
Hide resolved
GregP
force-pushed
the
state_machine_task_finished-refactoring
branch
from
9ba87f8 to
16d02c8
Compare
gmcculloug
reviewed
Nov 1, 2019
| @handle.create_notification(:type => :automate_service_provisioned, :subject => task.destination) if task.miq_request_task.nil? | ||
| when 'miq_provision' | ||
| final_message += "VM [#{task.get_option(:vm_target_name)}] " | ||
| final_message += "IP [#{task.vm.ipaddresses.first}] " if task.vm && !task.vm.ipaddresses.blank? |
There was a problem hiding this comment.
@GregP Rubocop called out this line which @tinaafitz was referencing in her comment. Along the the rubocop recommendation to use present? the condition can be simplified to:
if task.vm&.ipaddresses.present?
GregP
force-pushed
the
state_machine_task_finished-refactoring
branch
2 times, most recently
from
4d730e1 to
3ff16a0
Compare
gmcculloug
reviewed
Nov 4, 2019
| @handle.create_notification(:type => :automate_service_provisioned, :subject => task.destination) if task.miq_request_task.nil? | ||
| when 'miq_provision' | ||
| final_message += "VM [#{task.get_option(:vm_target_name)}] " | ||
| final_message += "IP [#{task.vm.ipaddresses.first}] " if task.vm.ipaddresses.present? |
There was a problem hiding this comment.
@GregP Thanks for updating this but you missed the & mentioned in my original comment #589 (comment) which adds safe navigation to the condition in place of the multi-part AND condition: if @task.vm && [email protected]?
See http://mitrev.net/ruby/2015/11/13/the-operator-in-ruby
This should really be: if task.vm&.ipaddresses.present?
GregP
force-pushed
the
state_machine_task_finished-refactoring
branch
from
3ff16a0 to
d5d7b7b
Compare
gmcculloug
approved these changes
Nov 4, 2019
|
Checked commit GregP@d5d7b7b with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
tinaafitz
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State Machine task finished method refactoring.
This PR is based on the issue below:
ManageIQ/manageiq#12038
@miq-bot add_label refactoring