Add unit tests for the outputaccumulator post processing. #422
Conversation
| """ | ||
| # create random correlation values between 0 and 1 | ||
| fragments_shape = fragments_df.shape | ||
| fragment_correlation = np.random.rand(*fragments_shape) |
There was a problem hiding this comment.
could we use a fixed seed here to make the tests reproducible?
if not, it would be good to print out the generated date, otherwise debugging tests will be a nightmare
There was a problem hiding this comment.
currently mocking the precursor_df, fragment_df and fragment correlation are completely random.
@GeorgWa do you think we can fix the seed for all of them ?
| fragment_flat_df = fragment_flat_df.sort_values(by="precursor_idx") | ||
| psm_flat_df["flat_frag_start_idx"] = np.arange(0, len(psm_flat_df) * 10, 10) | ||
| psm_flat_df["flat_frag_stop_idx"] = np.arange(0, len(psm_flat_df) * 10, 10) + 9 | ||
| psm_flat_df['nAA'] =psm_flat_df.sequence.str.len().astype(np.int32) |
There was a problem hiding this comment.
please install the pre-commit hook :-)
There was a problem hiding this comment.
This is strange, I already have them installed and ran it locally and all checks were passed.
There was a problem hiding this comment.
finally realized that pre-commit was turned off for tests (by me 🙈 )
|
was closed accidentally due to deletion of development branch |
|
@mo-sameh please change target to |
|
Closing this as the issue was caused by a discrepancy that made the pre-commit hook behave differently. A new PR, #450, has been opened with the correct target set to |
Added some unit test for the ms2 quality post processing step in the output accumulator.
Mainly: