Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to latest standards #227

Open
wants to merge 10 commits into
base: adapt_to_new_alphabase
Choose a base branch
from
Open

Adapt to latest standards #227

wants to merge 10 commits into from

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Jan 23, 2025 •
edited
Loading

see individual commit ..
next step would be to get rid of development branch, okay @jalew188 ?

edit:
apparently, for Mac-x64, torch=2.5.1 is not available: https://github.com/MannLabs/alphapeptdeep/actions/runs/12938838760/job/36089916306
how shall we deal with it? @jalew188 @GeorgWa

  • pin the version to a working number just for that architecture? -> would solve the issue for installers, but pypi install of stable would still not work for that architecture

@mschwoer mschwoer requested a review from jalew188 January 23, 2025 22:01
@mschwoer mschwoer marked this pull request as ready for review January 23, 2025 22:01
@mschwoer mschwoer requested a review from GeorgWa January 28, 2025 09:24
jalew188
jalew188 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalew188 jalew188 jalew188 approved these changes

@GeorgWa GeorgWa Awaiting requested review from GeorgWa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @jalew188