-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(textProps): adding ability to spread TextProps to help with accessibility #62
feat(textProps): adding ability to spread TextProps to help with accessibility #62
Conversation
🦋 Changeset detectedLatest commit: a14778c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Mookiies if you're only issue is font scaling and you'd like to disable for your whole app, you could add this to your index.js file: Text.defaultProps = Text.defaultProps || {}
Text.defaultProps.allowFontScaling = false That being said I agree this PR is important even to easily add testIDs if needed and of course allow to handle font scaling for the calendar only |
@danibonilha I appreciate the input and we are aware of disabling font scaling across the entire app. Unfortunately, that's not an option as out app requires additional accessibility and specific textfields need to scale while others are restricted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the contribution 🙏🏻
Just one feedback before we land this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last feedback @theonetheycallneo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @theonetheycallneo! Looks great
Adding ability to override TextProps when customizing the calendar especially for accessibility.
Resolves #61 and #36