Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result context refactor #7380

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

ch-iv
Copy link
Contributor

@ch-iv ch-iv commented Jan 12, 2025

Proposed Changes

Refactor the Result component and its children to use a context for identifying information (i.e course_id, grouping_id, role) instead of props.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) x

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@ch-iv ch-iv requested a review from david-yz-liu January 12, 2025 06:22
@coveralls
Copy link
Collaborator

coveralls commented Jan 12, 2025

Pull Request Test Coverage Report for Build 12781653739

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 5 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 91.867%

Files with Coverage Reduction New Missed Lines %
app/javascript/Components/Result/submission_selector.jsx 1 90.28%
app/controllers/criteria_controller.rb 8 80.0%
Totals Coverage Status
Change from base Build 12740251918: 0.09%
Covered Lines: 41273
Relevant Lines: 44245

💛 - Coveralls

@ch-iv ch-iv force-pushed the result-context-refactor branch from 129f03d to b8bdf37 Compare January 13, 2025 15:37
@ch-iv ch-iv force-pushed the result-context-refactor branch from b8bdf37 to e1bcb06 Compare January 13, 2025 15:53
@ch-iv ch-iv requested a review from david-yz-liu January 14, 2025 17:08
@ch-iv ch-iv requested a review from david-yz-liu January 15, 2025 05:10
@david-yz-liu david-yz-liu merged commit 610cff3 into MarkUsProject:master Jan 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants