Skip to content

Commit

Permalink
temporily ignore breaking changes on some proto files since buf doesn…
Browse files Browse the repository at this point in the history
…'t know any better'
  • Loading branch information
ParkMyCar committed Nov 12, 2024
1 parent 15286cd commit 6458a38
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 1 deletion.
12 changes: 12 additions & 0 deletions src/buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,26 @@ breaking:
- compute-types/src/sinks.proto
# reason: Ignore because plans are currently not persisted.
- expr/src/relation.proto
# reason: temporarily ignored by ParkMyCar
- repr/src/relation_and_scalar.proto
# reason: does currently not require backward-compatibility
- storage-client/src/client.proto
# reason: does currently not require backward-compatibility
- storage-client/src/statistics.proto
# reason: temporarily ignored by ParkMyCar
- storage-types/src/connections.proto
# reason: currently does not require backward-compatibility
- storage-types/src/connections/aws.proto
# reason: currently does not require backward-compatibility
- storage-types/src/connections/string_or_secret.proto
# reason: temporarily ignored by ParkMyCar
- storage-types/src/sinks.proto
# reason: temporarily ignored by ParkMyCar
- storage-types/src/sources/kafka.proto
# reason: temporarily ignored by ParkMyCar
- storage-types/src/sources/mysql.proto
# reason: temporarily ignored by ParkMyCar
- storage-types/src/sources/postgres.proto
lint:
use:
- DEFAULT
Expand Down
2 changes: 2 additions & 0 deletions src/repr/src/relation_and_scalar.proto
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
// Note: protobuf does not support cyclic imports. Thus, this file contains
// both, definitions from relation.rs and scalar.rs

// buf breaking: ignore (temporarily ignored by ParkMyCar)

syntax = "proto3";

package mz_repr.relation_and_scalar;
Expand Down
2 changes: 2 additions & 0 deletions src/storage-types/src/connections.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

// buf breaking: ignore (temporarily ignored by ParkMyCar)

syntax = "proto3";

package mz_storage_types.connections;
Expand Down
2 changes: 2 additions & 0 deletions src/storage-types/src/sinks.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

// buf breaking: ignore (temporarily ignored by ParkMyCar)

syntax = "proto3";

package mz_storage_types.sinks;
Expand Down
2 changes: 2 additions & 0 deletions src/storage-types/src/sources/kafka.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

// buf breaking: ignore (temporarily ignored by ParkMyCar)

syntax = "proto3";

package mz_storage_types.sources.kafka;
Expand Down
2 changes: 2 additions & 0 deletions src/storage-types/src/sources/mysql.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

// buf breaking: ignore (temporarily ignored by ParkMyCar)

syntax = "proto3";

package mz_storage_types.sources.mysql;
Expand Down
5 changes: 4 additions & 1 deletion src/storage-types/src/sources/postgres.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

// buf breaking: ignore (temporarily ignored by ParkMyCar)

syntax = "proto3";

package mz_storage_types.sources.postgres;
Expand Down Expand Up @@ -52,7 +54,8 @@ message ProtoPostgresSourceExportDetails {

// NOTE: this message is encoded and stored as part of source export
// statement options
// Be extra careful about changes, ensuring that all changes are backwards compatible
// Be extra careful about changes, ensuring that all changes are backwards
// compatible
message ProtoPostgresSourceExportStatementDetails {
mz_postgres_util.desc.ProtoPostgresTableDesc table = 1;
}

0 comments on commit 6458a38

Please sign in to comment.