Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: remove TEST SCRIPT source #25247

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

guswynn
Copy link
Contributor

@guswynn guswynn commented Feb 14, 2024

These never actually became useful, and their existence is actively getting in @petrosagg and my way as we refactor stuff

Motivation

  • This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@guswynn guswynn requested a review from a team February 14, 2024 19:05
@guswynn guswynn requested a review from a team as a code owner February 14, 2024 19:05
@guswynn guswynn requested a review from umanwizard February 14, 2024 19:05
Copy link
Contributor

@sploiselle sploiselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unfamiliar with what prompted us to build these in the first place, but it looks like an effort you undertook so am willing to cede to your judgment that they should be yanked from the code.

@guswynn guswynn enabled auto-merge February 14, 2024 19:11
Copy link
Contributor

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do love me a red diff.

@guswynn
Copy link
Contributor Author

guswynn commented Feb 14, 2024

@benesch its my penance for #25218

@guswynn guswynn merged commit 102315d into MaterializeInc:main Feb 14, 2024
68 of 70 checks passed
@guswynn guswynn deleted the delet-testscript branch February 15, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants