Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new buildkite pipeline names #26517

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

def-
Copy link
Contributor

@def- def- commented Apr 9, 2024

See #26502 for context

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@def- def- requested review from nrainer-materialize and a team April 9, 2024 09:13
@def- def- requested review from a team and benesch as code owners April 9, 2024 09:13
@def- def- force-pushed the pr-pipeline-names branch from 8b1a309 to 2500972 Compare April 9, 2024 09:14
@def- def- enabled auto-merge April 9, 2024 09:17
@def-
Copy link
Contributor Author

def- commented Apr 9, 2024

I just noticed this can't work yet since Github still waits for buildkite/tests instead of buildkite/test. I'll try to find where that is configured, but probably I can't change it.

@def- def- disabled auto-merge April 9, 2024 09:40
@def-
Copy link
Contributor Author

def- commented Apr 9, 2024

@benesch I guess you will have permissions to change that in https://github.com/MaterializeInc/materialize/settings (from buildkite/tests to buildkite/test) I renamed the Test pipeline back to Tests for now: https://buildkite.com/materialize/tests/settings/repository

@benesch
Copy link
Contributor

benesch commented Apr 9, 2024 via email

@nrainer-materialize
Copy link
Contributor

@def-: Rebased for your convenience to resolve conflicts introduced with the merge of #26497.

@def- def- enabled auto-merge April 9, 2024 13:59
@def- def- force-pushed the pr-pipeline-names branch from c88f1e3 to b7a09e5 Compare April 9, 2024 14:04
@def- def- merged commit 18a21bd into MaterializeInc:main Apr 9, 2024
75 checks passed
@def- def- deleted the pr-pipeline-names branch April 9, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants