[expr] Add a proptest for the is_monotone annotations #29538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Why think of counterexamples when the computer can do it?
(We could also add more functions to the abstract interpreter tests, which cover this codepath... but we can test this directly more cheaply for more functions, and this keeps any test failures closer to the problematic code.)
Tips for reviewer
Inspired by: #29514
This sadly produces a counterexample for
left
when passed a negative argument...'a' < 'aa' < 'z'
butleft(_, -1)
returns'' < 'a' > ''
. Concat seems fine in the second arg however!Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.