Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two wrong issue references #29782

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

def-
Copy link
Contributor

@def- def- commented Sep 30, 2024

Follow-up to #29773

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from a team as a code owner September 30, 2024 10:56
@def-
Copy link
Contributor Author

def- commented Sep 30, 2024

I just figured out why they went wrong, the replacements could catch part of an issue reference, for example materialize#12345 would get a replacement materialize#1234 -> database-issues#999, resulting in database-issues#9995, which is a totally invalid number. Will rerun my script with that fixed and see if anything else turns up.

@def- def- force-pushed the pr-fix-issue-references branch from d85d6cc to 975e4a0 Compare September 30, 2024 12:17
@def- def- requested a review from a team as a code owner September 30, 2024 12:17
@def- def- enabled auto-merge September 30, 2024 12:17
@def- def- merged commit 4afc453 into MaterializeInc:main Sep 30, 2024
77 checks passed
@def- def- deleted the pr-fix-issue-references branch September 30, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants