Add an EXPLAIN option to show the Equivalences Analysis
#30690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Attribute framework evolved into the Analysis framework. However, the EXPLAIN code still had a bunch of things whose names referred to Attributes. This commit just renames these things and fixes some comments.
ggevay
added
A-optimization
ggevay
force-pushed
the
explain-equivalences
branch
6 times, most recently
from
6139187 to
7ee105b
Compare
jkosh44
approved these changes
Dec 2, 2024
| @@ -3917,6 +3918,7 @@ impl WithOptionName for ExplainPlanOptionName { | |||
| | Self::SubtreeSize | |||
| | Self::Timing | |||
| | Self::Types | |||
| | Self::Equivalences | |||
There was a problem hiding this comment.
Can you add/update a parser test.
frankmcsherry
approved these changes
Dec 2, 2024
ggevay
force-pushed
the
explain-equivalences
branch
from
7ee105b to
6dc335e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of EXPLAIN options to show the results of various Analyses. These are quite useful for debugging. This PR adds an EXPLAIN option for the
EquivalencesAnalysis. This makes the behavior of theEquivalencesAnalysis easier to understand, especially for people who are not already familiar with all its details.Motivation
Tips for reviewer
The first 2 commits just do very minor refactorings. The main thing is in the 3rd commit.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.