Minor refactorings around HIR #31124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
approved these changes
Jan 21, 2025
| @@ -6124,7 +6131,7 @@ impl Visit<'_, Aug> for WindowFuncCollector { | |||
| } | |||
|
|
|||
| fn visit_query(&mut self, _query: &Query<Aug>) { | |||
| // Don't go into subqueries. Those will be handled by their own `plan_view_select`. | |||
| // Don't go into subqueries. Those will be handled by their own `plan_query`. | |||
There was a problem hiding this comment.
Just confirming it's not plan_select_from_where.
There was a problem hiding this comment.
Yep, plan_subquery/plan_nested_query calls plan_query. Even though plan_query does eventually call plan_select_from_where, it would be a little misleading to say that a subquery has its own plan_select_from_where, as if that were the whole subquery.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a number of trivial refactorings and comment tweaks around HIR.
The first commit renames
transform_expr.rstotransform_hir.rs. The old file name came from a time when the HIR types were just named...Expr, see 0c1e3e8.The second commit was discussed on slack.
The third commit does some minor comment tweaks in HIR planning.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.