Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copy_from] Refactor ranged requests, fix HTTP source #31174

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ParkMyCar
Copy link
Member

Stacked on top of #31144

This PR refactors ranged get requests so the logic for forming the header value is shared for both the HTTP and S3 source. It also fixes a bug where sometimes HEAD requests (which we use to get metadata for a file) are not supported, so we fallback to a GET request but quickly drop the body.

Motivation

Fix a bug in ranged HTTP requests I found in the demo today

Tips for reviewer

review only the final commit, the one titled "start, fix ranged requests"

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested review from a team as code owners January 24, 2025 00:23
@ParkMyCar ParkMyCar requested a review from jkosh44 January 24, 2025 00:23
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should probably add tests with the Range header if we don't already have some.

* move the creation of a Range header behind a trait
* use a GET request for the HTTP source if a HEAD request fails
@ParkMyCar ParkMyCar force-pushed the copy/fix-ranged-requests branch from d3ae6b9 to 17e11d0 Compare January 30, 2025 16:54
@ParkMyCar ParkMyCar merged commit 59763d1 into MaterializeInc:main Jan 30, 2025
78 checks passed
@ParkMyCar
Copy link
Member Author

LGTM, but we should probably add tests with the Range header if we don't already have some.

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants