catalog: Fix introspection source index migration #31204
Merged
+61
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous version of Materialize, the legacy builtin item migration framework would allocate new IDs for introspection source indexes when they needed to be migrated. As of 14cc787, introspection source index IDs are deterministic, so even when they're migrated using the legacy builtin item migration framework, they don't receive new IDs. This commit updates the legacy implementation of builtin item migrations for introspection sources indexes to account for the deterministic IDs. Fixes #MaterializeInc/database-issues/issues/8921
aljoscha
approved these changes
Jan 28, 2025
|
Thank you! I can confirm that it fixes the issue I've observed in #31158. |
jkosh44
added a commit
to jkosh44/materialize
that referenced
this pull request
Jan 28, 2025
In a previous version of Materialize, the legacy builtin item migration framework would allocate new IDs for introspection source indexes when they needed to be migrated. As of 14cc787, introspection source index IDs are deterministic, so even when they're migrated using the legacy builtin item migration framework, they don't receive new IDs. This commit updates the legacy implementation of builtin item migrations for introspection sources indexes to account for the deterministic IDs. Fixes #MaterializeInc/database-issues/issues/8921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous version of Materialize, the legacy builtin item migration framework would allocate new IDs for introspection source indexes when they needed to be migrated. As of
14cc787, introspection source index IDs are deterministic, so even when they're migrated using the legacy builtin item migration framework, they don't receive new IDs.
This commit updates the legacy implementation of builtin item migrations for introspection sources indexes to account for the deterministic IDs.
Fixes #MaterializeInc/database-issues/issues/8921
Motivation
This PR fixes a recognized bug.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.